Patch xdr and spec crates to support long type names - #2674
Closed
leighmcculloch wants to merge 5 commits into
Closed
Patch xdr and spec crates to support long type names#2674leighmcculloch wants to merge 5 commits into
leighmcculloch wants to merge 5 commits into
Conversation
leighmcculloch
changed the title
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Part of a stack of PRs that must merge in this order.
A first group of PRs deliver const-encoded contract specs, so that contract specs are produced at compile time instead of at proc-macro execution time. This provides the foundation for the capability to construct the specs from information that is not known at proc-macro execution and only known at compile time, like the fully qualified name of a type:
A second group of PRs deliver fully qualified type names in contract specs. Instead of a type having the name
Contextit will have the namesoroban_sdk::auth::Context. Qualified type names make it possible to uniquely identify types in the spec, even when they have the same name. This resolves several problems with contract specs the type identify problem (stellar/rs-soroban-sdk#1570), type aliases limitations (stellar/rs-soroban-sdk#1857 stellar/rs-soroban-sdk#1063), and optimise spec shaking data section size (stellar/rs-soroban-sdk#1978):What
Patch
stellar-xdrto stellar/rs-stellar-xdr#566, the soroban spec crates to stellar/rs-soroban-sdk#1970, andstellar-rpc-clientto stellar/rs-stellar-rpc-client#108, moving the workspace to stellar-xdr 28 and soroban-env-host 28.0.1, and adapt the CLI to the widened user-defined type name limit and the newScVal::ExecutableTagandContractExecutable::ExternalRefvariants.Why
Contract specs are moving to fully qualified user-defined type names, which need the widened name limit those PRs deliver, and the CLI has to be able to read and print specs produced by them.
Known limitations
The network-backed suites (RPC Tests, bindings typescript, Ledger Emulator Tests) fail because the test contracts now build against protocol 28 while the quickstart image still runs an older host, which rejects them with "contract protocol number is newer than host"; they stay red until a protocol 28 quickstart exists. Merging also depends on all three upstream PRs landing and releasing, with the
[patch.crates-io]git revisions replaced by published versions.